search

singnet / snet-sdk-python

Make gRPC calls to SingularityNET services programmatically using Python
MIT License
0 stars 1 forks source link

SDK/CLI separation: snet identity create #32

Open Necr0x0Der opened 1 month ago

Necr0x0Der commented 1 month ago

It's ok from SDK user perspective that CLI is installed together with SDK (although it can still be improved from the design perspective), but the necessity to run snet in command line is not good. In particular, to start using SDK, snet identity create is required.

How to reproduce:

SDK should not require running CLI manually and should not depend on its config since snet_sdk = sdk.SnetSDK(config) accepts config, which can contain anything needed (rather CLI should rely on sdk.SnetSDK)

PAY2109 commented 1 week ago

Dear @Necr0x0Der, Thank you for reporting this issue. We appreciate your feedback and apologize for any inconvenience caused. After thorough investigation, we have resolved this issue in the v3.3.0 of our app. SDK now creates identity automatically. Please update to the most recent release, and if you encounter any further problems, feel free to reopen this issue or create a new one. Best regards, Paul, SingularityNET

Necr0x0Der commented 1 week ago

Now, it works without explicit snet identity create, which is good. However, it creates config with identity.test, default endpoints, session on sepolia network. They seem to be ignored, so this is more or less ok, but they save my private key in config, which is not nice.