singnet / snet-upgradeable-owners-minting-policy

0 stars 1 forks source link

Token script - Audit #6

Open zmrocze opened 2 weeks ago

zmrocze commented 2 weeks ago

Token script

❌ A token holder can freely burn the protocol tokens he owns.

A token holder can burn the tokens he owns, but there is a constraint for the burning transaction to succeed. Namely, even if the token is being burned, there is a check that the transaction mints or burns just this single token. This excludes a plausible usecase where a token is exchanged for another token that gets minted. The usecase is still achievable but with a more complex 2-step process.

Timekiller7 commented 2 weeks ago

@zmrocze, why a token holder can't freely burn tokens? If usecase is connected with minting another possible protocol tokens(that aren't planned to be implemented)?

Renegatto commented 1 week ago

I am also not agree with the fact that this requirement is not satisfied. It depends on what do we mean by "freely", but literally nothing prevents token owner from doing that apart from fees (which should not be taken into account hence any Tx requires fees).

I would just left multi-asset burning/minting as a possible improvement.