singodiyashubham87 / Draw-it-out

An online Whiteboard application built using ReactJS & TailwindCSS utilising the HTML5 Canvas & the JavaScript Canvas API.
https://draw-it-out.vercel.app
MIT License
75 stars 162 forks source link

Added-title-name #512

Closed kekubhai closed 3 months ago

kekubhai commented 4 months ago

Issue Title: Title Name not showing for icons

closes #508

Type of change ☑️

What sort of change have you made:

Checklist: ☑️

How Has This Been Tested? ⚙️

I have made my changes and tested by running on the localhost server. It is working fine and showing my done relevenat changes as per the given requirement.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ❌ Failed (Inspect) Aug 1, 2024 3:34pm
draw-it-out-zbd1 ❌ Failed (Inspect) Aug 1, 2024 3:34pm
kekubhai commented 3 months ago

thank you for your important insights.I know the error needs a proper solution. I'll sure look into it and try to fix it as per your request

On Sat, Aug 3, 2024 at 4:05 PM Abdul Khalid @.***> wrote:

Assigned #512 https://github.com/singodiyashubham87/Draw-it-out/pull/512 to @kekubhai https://github.com/kekubhai.

— Reply to this email directly, view it on GitHub https://github.com/singodiyashubham87/Draw-it-out/pull/512#event-13749587175, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHNZX2ZHGF7D3DRBRU5KBL3ZPSXADAVCNFSM6AAAAABL22GVNOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG42DSNJYG4YTONI . You are receiving this because you were assigned.Message ID: @.*** com>

kekubhai commented 3 months ago

sorry for the delay,I couln't get time time to perfrom the necessary changes. It would be better if you could assign any other contributer to work on the issue. Thank you

0xabdulkhaliq commented 3 months ago

@kekubhai, Are you sure?

You have already done quite reasonable changes in this PR, for now you just need to refactor the changes you made. (You can refactor within 10 minutes, I already mentioned what needs be refactored).

Decision is yours, If you still willing to not to work on this issue then let me know about it. So that i can close this PR and Assign any other willing person for contribution.

kekubhai commented 3 months ago

Yes I'm completely okay with it. I have works which have tied me up. Deeply regret my inability to work on it. Please allow someone else to work on it

On Tue, Aug 6, 2024, 6:57 AM Abdul Khalid @.***> wrote:

@kekubhai https://github.com/kekubhai, Are you sure?

You have already done quite reasonable changes in this PR, for now you just need to refactor the changes you made. (You can refactor within 10 minutes, I already mentioned what needs be refactored).

Decision is yours, And I'm waiting for your Confirmation

— Reply to this email directly, view it on GitHub https://github.com/singodiyashubham87/Draw-it-out/pull/512#issuecomment-2270190630, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHNZX25ONZANRV2KUJ5XZRTZQAQ7TAVCNFSM6AAAAABL22GVNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQGE4TANRTGA . You are receiving this because you were mentioned.Message ID: @.***>

0xabdulkhaliq commented 3 months ago

As you wish @kekubhai 🤝