singpath / classmentors

Class Mentors UI
http://www.classmentors.com
MIT License
0 stars 8 forks source link

Fix cohort event names and link not showing up #96

Closed dinoboff closed 8 years ago

dinoboff commented 8 years ago

The error was caused by the “event” variable shadowing.

TODO: move the logics to classmentors/services.js.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.005%) to 7.75% when pulling 3957bdc462784433e9037e5fce92805b8f20bc7d on dinoboff:fix-cohorts into 0d736ff8a66c9069c64dabcfc2ca7b69db0dc0bb on singpath:master.

SingaporeClouds commented 8 years ago

This PR does not show the user services on their profile. Neither link works. /#/profile/PUBLIC_ID /#/profile/

image

dinoboff commented 8 years ago

The settings where not set. See the issue introducing admin settings (#76) for details.

They are now set and the services should show.