singpolyma / OpenPGP-Haskell

http://hackage.haskell.org/package/openpgp
ISC License
9 stars 6 forks source link

added more packet types #15

Closed alios closed 10 years ago

alios commented 12 years ago

added type constructor and parsers for:

singpolyma commented 12 years ago

Trust packets are really just a type tag that happens to be registered. Nothing about their structure is known. What is the advantage of using a TrustPacket constructor over using UnsupportedPacket ?

singpolyma commented 12 years ago

These patches seem to use spaces for both indenting as well as alignment. I can clean that up, but in future please use tabs for indentation.

singpolyma commented 12 years ago

This UserAttribute Packet implementation causes the tests to fail

singpolyma commented 12 years ago

Oops. Didn't mean to close this.

I've put a cleaned up version of these patches at https://github.com/singpolyma/OpenPGP-Haskell/tree/pull_request_15

I'm still unsure about TrustPacket, and the tests will need to accept UserAttribute. Also, I'd really prefer that UserAttribute actually parse the subpackets usefully: the partial implementation is a bit strange.

alios commented 12 years ago

The TrustPacket might be useful when parsing f.e. a gpg keyring.

singpolyma commented 12 years ago

Hmm... I'm not against the TrustPacket, I'm just not sure what it gets you over the UnsupportedPacket. I guess it means you don't have to pattern-match the actual tag number yourself. That might be enough.

singpolyma commented 11 years ago

https://github.com/alios/OpenPGP-Haskell/commit/80e22d225691a58295a89d969efec6305efdca87 https://github.com/alios/OpenPGP-Haskell/commit/0224e702e3d6a0eb5033f85c1168dfdc549cbfe3 https://github.com/alios/OpenPGP-Haskell/commit/8af759070e6800c309505d26e9043c6276a2220c

are the only feature commits that haven't been in some way merged.