Closed alios closed 10 years ago
Trust packets are really just a type tag that happens to be registered. Nothing about their structure is known. What is the advantage of using a TrustPacket constructor over using UnsupportedPacket ?
These patches seem to use spaces for both indenting as well as alignment. I can clean that up, but in future please use tabs for indentation.
This UserAttribute Packet implementation causes the tests to fail
Oops. Didn't mean to close this.
I've put a cleaned up version of these patches at https://github.com/singpolyma/OpenPGP-Haskell/tree/pull_request_15
I'm still unsure about TrustPacket, and the tests will need to accept UserAttribute. Also, I'd really prefer that UserAttribute actually parse the subpackets usefully: the partial implementation is a bit strange.
The TrustPacket might be useful when parsing f.e. a gpg keyring.
Hmm... I'm not against the TrustPacket, I'm just not sure what it gets you over the UnsupportedPacket. I guess it means you don't have to pattern-match the actual tag number yourself. That might be enough.
https://github.com/alios/OpenPGP-Haskell/commit/80e22d225691a58295a89d969efec6305efdca87 https://github.com/alios/OpenPGP-Haskell/commit/0224e702e3d6a0eb5033f85c1168dfdc549cbfe3 https://github.com/alios/OpenPGP-Haskell/commit/8af759070e6800c309505d26e9043c6276a2220c
are the only feature commits that haven't been in some way merged.
added type constructor and parsers for: