singpolyma / mnemonicode

Fork of http://web.archive.org/web/20101031205747/http://www.tothink.com/mnemonic/
MIT License
153 stars 20 forks source link

Word list doesn't fulfill stated criteria/requirements #10

Open sts10 opened 10 months ago

sts10 commented 10 months ago

I noticed this "Mandatory Criteria" section in the README of this project:

https://github.com/singpolyma/mnemonicode/blob/315aed6f1272cf2afa2eb1e1ed4a8879a49e5a6c/README#L28-L37

Unfortunately, some of these promised qualities are no longer true of the current list.

I don't know how crucial these qualities of the list are for various purposes the list is used for, but I think it'd be good to update the information to reflect the current list.

Also, a number of words on the list share five letter prefixes with other words on the list, meaning they are not unique. Here are the ones I was able to find:

Possible solutions

  1. Edit the README to match the current list. 1633 words; all words are between 3 and 7 letters long; and No word in the list is a prefix of another word (e.g. visit, visitor), which are all (still) true.
  2. Remove the 3 letters words from the list, making the 1st and 2nd criteria true. Still need to remove the statement that "Five letter prefixes of words are sufficient to be unique."
  3. Remove one of each of these pairs (and keep all existing 3-letter words on the list), we're down to 1,614 words. Then add 12 new words to get back to the originally promised 1626 words. You'd then only have to edit criteria to read "All words are between 3 and 7 letters long."