Closed jstanden closed 3 years ago
Ideally composer.json
for a 1.x
version would look like:
"require": {
"php": "^7.3 || ^8.0",
I didn't do that here because I didn't want to unilaterally remove support for PHP 5.4 through 7.2 without a discussion first. My main concern is Composer pulling openpgp-php in PHP8. I can update PHPUnit to 9.5 locally to verify the unit tests work.
TravisCI could be updated to test PHP8 once PHPUnit is updated; but that removes support for PHP versions earlier than 7.3.
Merging this into #109
Please see the discussion in #107.
This would work best if the
0.x
versions continue to support PHP 5.4 (if desirable), and a new1.x
release line supports PHP 7.4 and 8.x.A subsequent PR updates PHPUnit to 9.5 so the tests also run successfully on PHP 8.0. The current version-locked dependency uses the
each()
function, which has been removed.