search

singpolyma / openpgp-php

OpenPGP.php is a pure-PHP implementation of the OpenPGP Message Format (RFC 4880).
http://singpolyma.github.io/openpgp-php/
The Unlicense
179 stars 69 forks source link

Added 8.0 to the supported PHP versions in `composer.json`. #108

Closed jstanden closed 3 years ago

jstanden commented 3 years ago

Please see the discussion in #107.

This would work best if the 0.x versions continue to support PHP 5.4 (if desirable), and a new 1.x release line supports PHP 7.4 and 8.x.

A subsequent PR updates PHPUnit to 9.5 so the tests also run successfully on PHP 8.0. The current version-locked dependency uses the each() function, which has been removed.

jstanden commented 3 years ago

Ideally composer.json for a 1.x version would look like:

  "require": {
    "php": "^7.3 || ^8.0",

I didn't do that here because I didn't want to unilaterally remove support for PHP 5.4 through 7.2 without a discussion first. My main concern is Composer pulling openpgp-php in PHP8. I can update PHPUnit to 9.5 locally to verify the unit tests work.

TravisCI could be updated to test PHP8 once PHPUnit is updated; but that removes support for PHP versions earlier than 7.3.

jstanden commented 3 years ago

Merging this into #109