Bump version to php 7.3?

singpolyma / openpgp-php

OpenPGP.php is a pure-PHP implementation of the OpenPGP Message Format (RFC 4880).

http://singpolyma.github.io/openpgp-php/

The Unlicense

179 stars 69 forks source link

Bump version to php 7.3? #117

Closed Rotzbua closed 2 years ago

Rotzbua commented 2 years ago

"phpunit/phpunit": "^9.0" requires php>=7.3 so php versions below can not be tested properly. Php versions below are EOL anyway. Sodium is also not available. But composer still allows this old php versions. Shouldn't they be dropped?

If somebody wants to install the latest release anyway, it can be forced by composer with --ignore-platform-reqs or sticking to an old release.

singpolyma commented 2 years ago

sodium is optional (only gets used if you require that file) just like phpseclib is optional (but used so commonly in practise that it ended up listed as a requirement), but you're right that even CI doesn't run on anything less than 7.3 anymore so maybe we should drop the older versions.