Closed allan-simon closed 1 year ago
@singpolyma this PR is now ready for review , all tests are green and all examples works :)
Sorry for the long delay. This mostly looks good to me. Just a few small questions, and maybe you could rebase down into a non-WIP commit with a message describing the high-points of the changes made?
Thanks so much.
no worry for the delay :) I've adressed all your comments and reword the commit message
there's only your comment about the exemple code remaining, feel free to propose a suggestion on how you want me to do the code, I will add it, after all it's your library so I will rename variable as you like :)
@singpolyma Hi - if this PR is pretty much ready to go, is there any chance it could be merged? Your library is exactly what I need but I'm locked to phpseclib 3 by other dependencies, so it would really help me out 🙏
@singpolyma - any update on this PR? Like other users here I need to use phpseclib v3 due to dependency constraints
@singpolyma - any update on this PR? Like other users here I need to use phpseclib v3 due to dependency constraints
Hi, I would need this update too :)
Merged as 8b08661a65a2a40cda056a61e6ffa67eec5a4aa6
thanks a lot ! is it possible get a tagged version so that we can get back "stable" version in our composer :angel:
thanks again to have found the time to review and merge it :)
hi @singpolyma is it possible to release this one as tagged version? thanks a lot for your time on maintaining this library!
ok so basically now there's only the test
Decryption::testDecryptRoundtrip
failingI'm currently investigating why because this fails
While this works :
i.e it seems that instanciating one packet at a time cause it to fails (while it was working on master)