Fix misc minor issues to improve PHP 8.1 compatibility - Githubissues

singpolyma / openpgp-php

OpenPGP.php is a pure-PHP implementation of the OpenPGP Message Format (RFC 4880).

http://singpolyma.github.io/openpgp-php/

The Unlicense

179 stars 69 forks source link

Fix misc minor issues to improve PHP 8.1 compatibility #124

Closed stripthis closed 2 years ago

stripthis commented 2 years ago

Hello,

This is a pull request to fix some small issues we found when running passbolt testsuite against php8.1. Mostly:

PHP8.1 deprecation warning with regards to IteratorAggregate and ArrayAccess interface
Some array type issues when dealing with some of our specific error scenarios
A test assertion to skip Cast5 tests as OpenSSL for example doesn't support the CAST5-CFB algorithm anymore on Ubuntu 22.04.

Thank you for your work! 👋