search

singular-labs / Singular-SKAdNetwork-App

Sample apps demonstrating the logic needed to implement SKAdNetwork as an ad network, publisher and advertiser.
https://www.singular.net
MIT License
79 stars 19 forks source link

Used curve is incorrect #8

Open dynamix opened 4 years ago

dynamix commented 4 years ago

The example uses p256 but Apple requires p192.

egorlitvinenko commented 4 years ago

Confirmed https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network

However, it looks like they changed the docs.

dynamix commented 4 years ago

They did, which is annoying because the key we submitted in the beginning used secp256r1. The choice of prime192v1 is questionable and I wrote them about it (nobody uses it, not all libs support it, it is considered not very secure, more hash digest than bits in the curve ...)

danielxt7 commented 4 years ago

thanks @dynamix - yep, we also suspect this changed... we are updating the repo to use prime192v1 - thx!

bzarzoza commented 3 years ago

that guidance has changed once again to prime256v1

old: http://web.archive.org/web/20200920102544if_/https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network new: https://developer.apple.com/documentation/storekit/skadnetwork/registering_an_ad_network

fmaschmeier commented 3 years ago

change to p192 plus a note in readme to highlight necessary equality in keypair and adserver -> addressed with #10