search

singular-labs / Singular-iOS-SDK

MIT License
6 stars 3 forks source link

M1 support #22

Closed revolter closed 2 years ago

revolter commented 3 years ago

Add support for running an app using Singular SDK on M1 Macs in the Simulator app.

In other words, if you're using the Singular SDK alongside another SDK that does support M1's architecture, trying to run the app in the Simulator fails. So we're blocked using only real devices.

The .xcframework should bundle the arm64 binary for Simulator.

revolter commented 2 years ago

The error that I'm receiving is this:

Could not find module 'FBSDKCoreKit' for target 'x86_64-apple-ios-simulator'; found: arm64, arm64-apple-ios-simulator, at: /Users/revolt/Library/Developer/Xcode/DerivedData/Mondly-dsjsiejaojowwseybqfkevcqdywu/Build/Products/Debug-iphonesimulator/FBSDKCoreKit/FBSDKCoreKit.framework/Modules/FBSDKCoreKit.swiftmodule

And this is because the Facebook SDK doesn't offer anymore support for x86_64 simulators, but only for the new arm64 simulators. So, the Singular SDK should also provide support for arm64 simulators.

omribaraksingular commented 2 years ago

Hi @revolter ,

Thanks for bringing this to our attention. Singular iOS latest SDK supports both x86_64 and arm64 simulators.

Best, Omri Barak Product Manager

revolter commented 2 years ago

I can confirm that it works 🎉 Thank you!