singularity-energy / open-grid-emissions

Tools for producing high-quality hourly generation and emissions data for U.S. electric grids
MIT License
76 stars 5 forks source link

Remove add_subplant_id optional argument #361

Closed rouille closed 6 months ago

rouille commented 6 months ago

Purpose

Clean and allocate generation and fuel in EIA-923 data at sub-plant level only. The option to do it at the plant level was bugged (see #360) and is now deactivated. Closes #360. Closes CAR-4207.

Add missing typehints and docstrings to the functions

What the code is doing

Remove add_subplant_id from functions and discard if logic.

Testing

Run 2012 pipeline successfully

Where to look

The oge.data_cleaning.clean_eia923 and oge.data.create_primary_fuel_table are the 2 functions that are modified. Add missing typehints and docstrings to these functions.

Usage Example/Visuals

N/A

Review estimate

5min

Future work

N/A

Checklist

grgmiller commented 6 months ago

Also make sure to add "Closes CAR-XXXX" to the PR description to tag the linear issue

rouille commented 6 months ago

Also make sure to add "Closes CAR-XXXX" to the PR description to tag the linear issue

Added.