singularityhub / circle-ci

example builder for Singularity containers using Circle Continuous Integration, circle-ci
7 stars 10 forks source link

setup.sh: import cycle not allowed #7

Closed tschoonj closed 5 years ago

tschoonj commented 5 years ago

Hi @vsoch

I am running into trouble when setup.sh executes go get -u github.com/golang/dep/cmd/dep:

import cycle not allowed
package github.com/golang/dep/cmd/dep
    imports bytes
    imports errors
    imports runtime
    imports internal/bytealg
    imports internal/cpu
    imports runtime
Exited with code 1

You can also see this in my build at https://circleci.com/gh/DiamondLightSource/Savu/6

vsoch commented 5 years ago

I suspect it's because the install doesn't use modules anymore. Let me see if I can do a fix.

vsoch commented 5 years ago

I mean, does use modules. :)

tschoonj commented 5 years ago

Thanks for looking into this!

vsoch commented 5 years ago

Also, don't forget about the Singularity Orbs:

They were generated from this original recipe, albeit it's fairly simple to just use this directly. For example usage, take a look at Singularity Python tests, and whatever other CircleCI projects I have that use Singularity :)

vsoch commented 5 years ago

Actually, I'll update the example here to use it :) It just passed testing, will merge asap.

vsoch commented 5 years ago

The config is updated and fixed, it now uses the Circle orbs and the user can specify the Singularity version, etc. https://circleci.com/gh/singularityhub/circle-ci/46

tschoonj commented 5 years ago

That looks awesome, will give it a go right away!

Thanks!