singularityhub / shpc-registry

A remote registry for Singularity Registry HPC 🖊️
https://singularityhub.github.io/shpc-registry/
Mozilla Public License 2.0
13 stars 18 forks source link

update nvidia containers and remove sbom/vex artifacts #195

Closed vsoch closed 5 months ago

vsoch commented 5 months ago

This will close #194

clessig commented 5 months ago

Great, thank you.

I can't directly test it since I use shpc on JUWELS and I need to wait until the package is updated there.

vsoch commented 5 months ago

If you clone that PR branch and change the registry entry in your settings.yaml to that clone path root it will install from it. It’s a filesystem registry.

vsoch commented 5 months ago

I'm happy to merge without that, but if it goes in (and fails in CI) I'll have to undo the addition. Or if there is another issue I'd ask you to please follow up with a PR. Let me know your preference! It would be ideal to test.

clessig commented 5 months ago

Hi, please go ahead and merge. I won't have time to test it at the moment. (I am just using shpc at the moment so figuring out how and where to change the settings.yaml etc would take me some time, which I unfortunately don't have at the moment.)

vsoch commented 5 months ago

Also your interest in this container led me to find a bug with tag parsing - nvidia recently added vex and sbom (as tags) and we weren't filtering them out! Now we are. So thank you!