singularityhub / sregistry-cli

Singularity Global Client for container management
https://singularityhub.github.io/sregistry-cli/
Mozilla Public License 2.0
14 stars 18 forks source link

Simplifying client import to be done once #202

Closed vsoch closed 5 years ago

vsoch commented 5 years ago

This pull request will (hopefully) address #200. The core issue was that I had a bad design that looked like this:

What seems to be happening (and likely due to the messiness of the above) is that it was switching between 3 states of client, and it for some reason never got to s3. I've been unhappy with this design since I created it, so I thought now would be a good time to fix it up. The fixed design looks like this:

The main change to fix this was, instead of instantiating the client in sregistry.main, I removed that entirely and the functions import "get_client" and then use it when appropriate.

Additionally, I went through and updated many "bot.error" messages followed by "sys.exit" to just be "bot.exit" and updated docs.

vsoch commented 5 years ago

@tschoonj please review at your leisure!

tschoonj commented 5 years ago

Thanks @vsoch. That will be for tomorrow...

vsoch commented 5 years ago

This will now close #206 -

vsoch commented 5 years ago

@tschoonj I'm going to keep the credentials required for now. We can follow up with another PR.