search

singularityhub / sregistry-cli

Singularity Global Client for container management
https://singularityhub.github.io/sregistry-cli/
Mozilla Public License 2.0
14 stars 18 forks source link

Fix return value usage on error #210

Closed tschoonj closed 5 years ago

tschoonj commented 5 years ago

WORK IN PROGRESS

@vsoch this is my fix for get. I am not sure what to do if there are multiple images passed: should I abort after the first failure instead?

vsoch commented 5 years ago

I would actually suggest that we change the functions to just be run for one image at a time. There is no real benefit to trying to do multiple at once - the user can just run the function multiple times, and each would correspond with a clean return code.

There are a few spots in the docs that mention being able to do multiple (when interacting with the python client) so we should update those too.

tschoonj commented 5 years ago

Ok makes sense. will do that tomorrow

tschoonj commented 5 years ago

I think I have put in all the changes I wanted to, let me know if you need me to do anything else!

vsoch commented 5 years ago

The one final detail is to add notes for what you changed in the CHANGELOG.md, and to bump the version.

tschoonj commented 5 years ago

I always forget that!

vsoch commented 5 years ago

And this is why I'm here, this is my purpose! :)

https://www.youtube.com/watch?v=X7HmltUWXgs

vsoch commented 5 years ago

https://pypi.org/project/sregistry/0.2.13/

tschoonj commented 5 years ago

Thanks!

By the way, I dont know if you have anything to do with https://www.sylabs.io/singularity/whos-using-singularity/, but I sent an email some time ago asking them to add my employer's logo to the list, but so far nothing has happened... Could you perhaps remind the people managing that website? Not hugely important but we are proud Singularity users here 😄

vsoch commented 5 years ago

I was an original developer (and continue to develop) but I'm not employed by Sylabs. I think your best bet would be to ask on slack, or open an issue in the user-docs (that are connected to that site). https://github.com/sylabs/singularity-userdocs

tschoonj commented 5 years ago

Ok, thanks will do that!