search

singularityhub / sregistry-cli

Singularity Global Client for container management
https://singularityhub.github.io/sregistry-cli/
Mozilla Public License 2.0
14 stars 18 forks source link

Fix google backend pull exit return values #253

Closed tschoonj closed 4 years ago

tschoonj commented 4 years ago

This commit ensures that the google backends pull methods result in the program exiting with return code 1 instead of 0, when the image could not be found. I find this a useful feature to exploit in scripts...

vsoch commented 4 years ago

@tschoonj I'm no longer using pylint, so if you want to rebase with master it should skip that bit. I have mixed feelings because pylint will catch the extra imports, etc., but I think just using black will make it much easier to contribute.

vsoch commented 4 years ago

Also, don't forget to bump the version and update the changelog. Did you want to freeze the version of the http library here too, to fix #252 ?

vsoch commented 4 years ago

@tschoonj I think you missed my comment above, see https://github.com/singularityhub/sregistry-cli/pull/253#issuecomment-585331887 !

vsoch commented 4 years ago

Perfecto! Testing passing - installing this works for you locally?

And sorry for the delay, had some soft work to do this morning (releasing podcast)

tschoonj commented 4 years ago

Yep works locally for me.

Where can I find your podcasts by the way?

vsoch commented 4 years ago

RSE Stories! Here is today's episode https://us-rse.org/rse-stories/2020/keoni-gandall/

vsoch commented 4 years ago

okay, and on pypi! https://pypi.org/project/sregistry/0.2.34/ This will trigger the conda bot to create a new release, and then we can update versions there. Does that work? Thank you kindly for taking charge to fix this up!

tschoonj commented 4 years ago

Nice! I will try and give it a listen soon. By the way I am changing jobs in three weeks and will be a research software engineer myself then 😄

tschoonj commented 4 years ago

Yep conda bot should pick up on this within the hour.

vsoch commented 4 years ago

Wow awesome!! Any details to share? And can I interview you on RSE Stories? We can schedule it for a few months down so you have some time to settle in :)

tschoonj commented 4 years ago

I will be working at the Rosalind Franklin Institute, which is right across from my current employer Diamond Light Source. Not sure exactly what I will be doing, but it will definitely involve cloud computing and HPC....

I am not sure my activities will be interesting enough for an interview, but I will keep it in mind 😄

vsoch commented 4 years ago

Well, based on the fact that I can click that site and it already seems cool and I have a lot of questions, I think you would be a good fit :) You know, most folks that are on the show (that result in really interesting episodes!) say similar - I think it's more that your life is so familiar to you it doesn't seem interesting, but for another RSE with a very different reality, it's new and exciting (and we generally like to hear about these other RSE realities / stories).