singularityhub / sregistry

server for storage and management of singularity images
https://singularityhub.github.io/sregistry
Mozilla Public License 2.0
103 stars 42 forks source link

Update to container push to honor new binary #279

Closed vsoch closed 4 years ago

vsoch commented 4 years ago

This pull request will address #273 - specifically, we had a typo in the final tag function where, given that a container was not frozen, we would want to keep the newly uploaded one and clean up the previous one. In addition, the django signal wasn't firing to clean up any image files that were no longer used.

To test this pull request:

Things to test

I tested these points, and I'd like one more tester for a sanity check. @RonaldEnsing I'm hoping since the issue is important to you that you might be able to - and please there is no rush! Take whatever time that you need.

Signed-off-by: vsoch vsochat@stanford.edu

RonaldEnsing commented 4 years ago

Yes, this works. Thanks a lot! I think this is good to merge.