search

singularityhub / sregistry

server for storage and management of singularity images
https://singularityhub.github.io/sregistry
Mozilla Public License 2.0
103 stars 42 forks source link

Can't find image when capital letter in image name #295

Open qianglchina opened 4 years ago

qianglchina commented 4 years ago

When pulling a image with capital letter, I got error like this:

FATAL: While pulling library image: image app/Habc (amd64) does not exist in the library

Howerver, the image is found in UI and can be downloaded.

When image name changed to app/habc, it works fine

vsoch commented 4 years ago

Is the pull via Singularity? It’s likely the case that their client lowercases everything, and the easiest thing to do is not create collections and containers with capital letters. But I thought I already enforced this - how did you go about creating the collection with the capital letter? If you can give me full steps to reproduce creating the collection, pushing, and then pulling I can try to reproduce.

qianglchina commented 4 years ago

Yes. First I push image to sregistry use command like this: singularity -U push Habc.sif library://app/Habc:2020 And app/Habc:2020 is found in UI. Then I pull the image from sregistry: singularity pull app/Habc:2020 FATAL: While pulling library image: image app/Habc (amd64) does not exist in the library

vsoch commented 4 years ago

One more question for you - did you try including your username? E.g.,:

singularity -U push Habc.sif library://<username>/app/Habc:2020
vsoch commented 4 years ago

@qianglchina once you've reported the result of the above, there are two paths we can take to fix this, and I'd like your opinion. The main issue is that the previous push / upload has restriction on capitals letters (meaning that everything is lower cased) so that (akin to Docker Hub) you can only push and then pull lowercase collections. However, when I added the library endpoint, I forgot to add this constraint, which is why you can push a capitalized collection name (and then not pull it). So this means we can do one of the following:

  1. add the parsing to enforce all lowercase to push so your original push would have resulted in app/habc:2020 - this is what my preference would be to enforce all lowercase.
  2. remove the restriction globally (which is not my preference).

Let me know your thoughts! I can put in a fix for you to test once we've talked.

qianglchina commented 4 years ago

I prefer the first way either since Docker Hub to do so. And if sregistry UI gives the right infomation, there would be no misunderstanding.

vsoch commented 4 years ago

hey @qianglchina I'd be happy to fix this up! Right now I am putting #298 as priority, so if you have some bandwidth to take a look / test there, it would be greatly helpful! Once that is merged, it should be fairly easy to fix up this small issue.

vsoch commented 4 years ago

@qianglchina could you please test this with current master (just merged #298) and provide an update on the issue? If the issue persists, we can take another look and address. Thanks for your patience and apologies for the delay!