singularityhub / sregistry

server for storage and management of singularity images
https://singularityhub.github.io/sregistry
Mozilla Public License 2.0
103 stars 42 forks source link

(maint) update prepare_instance.sh #341

Closed vladdoster closed 3 years ago

vladdoster commented 3 years ago
vsoch commented 3 years ago

The issue with these changes are that if the cd does fail, there is no message to the user (it's silent). And since we aren't deleting files, there really isn't any risk to doing it - we just are building a docker container, and likely if the user doesn't cd they will see a message that there is no Dockerfile in the context. This script is also not really intended to be run non-interactively, at least I mostly did this manually. So I think the changes to add quotes are good, but I'm not sure we need cd X || exit - it seems like a bit much, and could actually be confusing. Would it make sense to instead check that the install path exists before cding there?