(maint) fix anti-patterns and improve performance

[vladdoster]

• refactor unnecessary else / elif when if block has a continue statement

• refactor unnecessary else / elif when if block has a raise statement

• refactor unnecessary else / elif when if block has a return statement

• remove duplicate dictionary key(s)

• remove unnecessary return statement

• remove unnecessary use of comprehension

• use _ to denote var is unused

• change methods not using its bound instance to staticmethods

  The method doesn't use its bound instance. Decorate this method with @staticmethod decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation.

• remove implicit object from the base class

  The class is inheriting from object, which is implicit under Python 3 , hence can be safely removed from bases.

• use literal syntax instead of function calls to create data structure

  This is because here, the name dict must be looked up in the global scope in case it has been rebound. The same goes for the other two types list() and tuple().

  
  Out[1]: 9.560388602000103
  
  In [2]: timeit.timeit(stmt="{}", number=100000000) Out[2]:
  1.685333584000091
  
  In [3]: timeit.timeit(stmt="tuple()", number=100000000) Out[3]:
  4.509182139000131
  
  In [4]: timeit.timeit(stmt="()", number=100000000) Out[4]:
  0.5455615430000762
  
  In [5]: timeit.timeit(stmt="list()", number=100000000) Out[5]:
  7.356000728000254
  
  In [6]: timeit.timeit(stmt="[]", number=100000000) Out[6]:
  1.573771306999788 ```

• fix membership test

  tests for membership should use the form x not in the_list rather than not x in the_list. the former example is simply more readable.

• use set comprehension

  although there is nothing syntactically wrong with this code, it is hard to read and can be simplified to a set comprehension. using set comprehension is more performant since there is no need to create another transient list.

• update singleton comparison

  comparisons to the singleton objects, like true, false, and none, should be done with identity, not equality. use “is” or “is not”. identity checks are faster than equality checks.

Signed-off-by: Vladislav Doster mvdoster@gmail.com

[vladdoster]

Mhm.... not quite sure what I am missing here.

[vsoch]

@vladdoster it's usually a mismatch in the version of black - you can check the message in the CI to see what version is installed.

These are great changes! I will try to make some time to review them soon.

[vsoch]

Oh and don't worry too much about black - when we're finished up review I'd be happy to pull, run the matching version, and update the PR.

[vsoch]

Taking a look again! @vladdoster for future reviews could you wait until the end to rebase? it makes it hard to see what you changed (and I'll need to review the entire thing again instead of just changes).

[vsoch]

okay I still see a lot of the static methods applied - let me know when this is ready again for review!