search

singularityhub / sregistry

server for storage and management of singularity images
https://singularityhub.github.io/sregistry
Mozilla Public License 2.0
103 stars 42 forks source link

Update minio.py with ssl query #383

Closed hashkeks closed 2 years ago

hashkeks commented 2 years ago

Added a short if-statement to query if SSL is being used in the setup to automatically set the 'verify' attribute of the s3 and s3_external session.client objects. See https://github.com/singularityhub/sregistry/issues/380 for more information.

vsoch commented 2 years ago

Awesome! A few suggestions / questions:

  1. Couldn't the MINIO_SSL variable just be used for VERIFY instead of creating a new boolean?
  2. Could you please update the VERSION in the root and the CHANGELOG.md?
hashkeks commented 2 years ago

Thanks for the suggestions, @vsoch. Will close this pull request and make a new one with the changes.