search

singularityhub / sregistry

server for storage and management of singularity images
https://singularityhub.github.io/sregistry
Mozilla Public License 2.0
103 stars 42 forks source link

Add missing package #418

Closed SethosII closed 1 year ago

SethosII commented 1 year ago

Package python-jose is required for LDAP authentication.

vsoch commented 1 year ago

Should this perhaps be here as another line https://github.com/singularityhub/sregistry/blob/1cce4be2812eecf4ee0be76da9d6e8078b4bdfa1/Dockerfile#L55 if it’s only needed for LDAP?

SethosII commented 1 year ago

I don't think it's only required for LDAP. I also checked it and social-auth-core has it listed as a requirement. A quick search in their GitHub repository shows no LDAP specific things.

vsoch commented 1 year ago

That works for me then - it's worrisome they don't install one of their dependencies and put that burden on us.