search

singularityhub / sregistry

server for storage and management of singularity images
https://singularityhub.github.io/sregistry
Mozilla Public License 2.0
103 stars 42 forks source link

allow setting of gitlab scope from env or settings file #435

Closed karcaw closed 1 year ago

karcaw commented 1 year ago

This changes the default of SOCIAL_AUTH_GITLAB_SCOPE to the empty list, as well as allowing it to be set by the settings file or the env. Of note, the social login adds read_user to this list, which is enough for login, and as such the [] default should be proper in most cases.

This should fix #434 This Should fix #431

I also added a settings dumper that is useful for debugging, and shell scripts, which may help with #432

vsoch commented 1 year ago

Looking good! Last item of action - please bump the version in https://github.com/singularityhub/sregistry/blob/master/VERSION and add a note to the CHANGELOG. If you'll be making a few PRs, we will put them all under this new version.

vsoch commented 1 year ago

@karcaw for linting, you can install pre-commit locally (and use our requirements.dev.txt to do so) and fix the errors

https://github.com/singularityhub/sregistry/blob/ee23901a00a23d0d2a65fab5f484c803cfd60e44/.github/workflows/main.yml#L21-L29