search

sinhrks / ggfortify

Define fortify and autoplot functions to allow ggplot2 to handle some popular R packages.
Other
527 stars 65 forks source link

ggfortify + tidymodels #196

Open briatte opened 5 years ago

briatte commented 5 years ago

Hello,

First, thank you for this exceptional package!

Second, I'd like to add to the remarks made in #17 and #179.

ggfortify integrates really well with the broom package, which became part of a larger effort to work on statistical models with tools like 'tidy data' and ggplot2:

https://github.com/tidymodels

How about making ggfortify part of that family of packages? Would that give it more visibility and/or help its current developer base with extending/improving it?

Poking @alexpghayes and @dgrtwo in case they might already have thought about this.

Again, many thanks for the package, and apologies if the question has already been answered elsewhere.

terrytangyuan commented 5 years ago

Thanks for opening the discussion! I’d definitely love to transfer ggfortify to a Github org and tidymodels seems to be a good fit, especially given that broom is there. @sinhrks What do you think?

Also cc @hadley as we have discussed this over email long time ago. Maybe it’s good to revisit this.

alexpghayes commented 5 years ago

I haven't thought about this, but am curious to explore ggfortify more. I think @topepo is probably the person to chat with.

topepo commented 5 years ago

I'd be happy to add some methods but it would be helpful to add specific issues to the various packages for what you want. In some cases, the tidy method might get you there.

terrytangyuan commented 5 years ago

@topepo Thanks for joining this conversation! Could you elaborate on what you meant by "add some methods"?

Also unfortunately I was not able to get any response from @sinhrks since he isn't available for the last couple of years so I doubt that this repo can be directly transferred to tidymodels org. I've been the sole maintainer of this package now.

If tidymodels/broom community can help bring some visibility and contributors, I'd be very appreciated. If anyone has any suggestions on how to move forward and what the best way to integrate/collaborate with tidymodels/broom, I am all ears.

topepo commented 5 years ago

I don't think that it needs to be (or should be) in tidymodels.

I was suggesting that if someone wanted fortify() to work with some of the objects produced by a tidymodels package, they should let us know some specifics so that we can add some S3 methods that fortify() can use.

terrytangyuan commented 5 years ago

I don't think that it needs to be (or should be) in tidymodels.

Any reason for that?