search

sinkaroid / booru

Python bindings for booru imageboards
https://sinkaroid.github.io/booru
MIT License
25 stars 3 forks source link

skip banned posts when parsing, because they contain no files #7

Closed f8upd8 closed 1 year ago

f8upd8 commented 1 year ago

Allows get_images to work when encountering banned posts without image files.

da-vinci-bot[bot] commented 1 year ago

Hey?! @MalOMaw We will get back to you soon! OwO

Click here to make your day UmU ![abc](https://gitlab.com/d0g/servant/-/raw/master/pat/44ea08cece348b3eb606d42b1dcefe71c0d48bd6.png "UmU")
sinkaroid commented 1 year ago

@MalOMaw could you enable the workflows check in your PR, why the CI is not running? just want to ensure there is no breaking flow with other boorus and we can see the danbooru result

sinkaroid commented 1 year ago

Hey, I have test with your flow, I think is_banned does not affect at all though, idk why it's still throwing the KeyError despite i["file_url"] always there

f8upd8 commented 1 year ago

Hi, I assume you rewritten and deleted the module? If banned danbooru posts don't affect it, I think we can close the PR

sinkaroid commented 1 year ago

Yes, I realized the old version was bad behaviour.

  1. intended for async usage but still depends on requests lib #3
  2. injecting query parameters for block image with -{block} eg: `-furry` is takes more arguments on each booru, and sometime exceed the limit tags

should be fixed now