Slight cleanup to conversion validation and potentially performance

sinkillerj / ProjectE

ProjectE. A complete rewrite of EE2 for modern Minecraft versions.

MIT License

395 stars 203 forks source link

Slight cleanup to conversion validation and potentially performance #2169

Closed pupnewfster closed 2 years ago

pupnewfster commented 2 years ago

I addressed the first few things in https://github.com/sinkillerj/ProjectE/issues/2133#issuecomment-1008120735, but for the last part about the loop, if I understand correctly:

for all new ingredients it is getting any existing uses for the ingredient
removing the old conversion for them.

If it looped the old conversion then it would be removing conversions that might not exist with the new one that is overwriting it I think? So I left it as is for now as I think that may be intended.

pupnewfster commented 2 years ago

CC @MaPePeR as it isn't letting me use the request review feature to notify you via github.

MaPePeR commented 2 years ago

Looks good to me. 👍