sinkillerj / ProjectE

ProjectE. A complete rewrite of EE2 for modern Minecraft versions.
MIT License
404 stars 209 forks source link

Interaction between Energy Condenser Mk 1 and Inventory Tweaks sorting function destroy contents of condenser. #2238

Open togreglove opened 2 years ago

togreglove commented 2 years ago

Tickets that do not conform to this template will be closed without comment

Exact ProjectE version (do not say "latest", "latest on Curse", or similar):

ProjectE-1.18.2-PE1.0.1.jar

Exact Forge version:

forge-1.18.2-40.1.79-installer.jar

[Bonus] Pack and pack version:

All The Mods 7: To The Sky 1.0.7

Link to crash log (please use a paste site, do not attach the .txt or paste the log inline):

N/A

Steps to reproduce:

  1. Place an item in the target item slot of Energy Condesner Mk 1 (in my case, netherite ingots)
  2. Place or pipe in items with emc, which get transformed into netherite.
  3. Open Energy Condenser Mk 1, seeing all the wonderful stacks of netherite you have accumulated.
  4. Middle click out of habit, causing Inventory Tweaks to attempt to sort the inventory.
  5. Have all items in the Energy Condenser Mk 1 disappear forever.

What I expected to happen:

Items remain in chest, filling slots starting from the upper left and condensing stacks. If there are unconverted items, have them come after converted items in a similar, filled stack pattern.

What happened instead:

Poof. All gone. Hours of work and tons of EMC. Poof.

I do not understand why you cannot insert the target item into an EC that is converting to that item. What I suspect is happening is that inventory tweaks is removing all items from the chest, storing them in some internal buffer, and then attempting to place them back in the chest in a sorted order. But, when it tries, the EC prevents the insertion and the items disappear forever.