sinkillerj / ProjectE

ProjectE. A complete rewrite of EE2 for modern Minecraft versions.
MIT License
394 stars 203 forks source link

pregenerated_emc.json being neither written to nor read from #2251

Closed AmmoniumX closed 1 year ago

AmmoniumX commented 1 year ago

Exact ProjectE version (do not say "latest", "latest on Curse", or similar): ProjectE-1.18.2-PE1.0.1.jar

Exact Forge version: Forge 40.1.0

Link to crash log (please use a paste site, do not attach the .txt or paste the log inline): N/A

Steps to reproduce:

  1. Set pregenerate = true inside mapping.toml on the config folder

What I expected to happen: A file called pregenerated_emc.json would be created in the config folder

What happened instead: File was not generated

Issue also happens the other way around, with reading from the file instead of writing to:

Steps to reproduce:

  1. Place a valid pregenerated_emc.json file on the config folder and set pregenerate = true inside mapping.toml

What I expected to happen: ProjectE would read the values on the json file, changed values from the original would show up as changed, items which don't originally have EMC but have been given EMC on the json file would show up with the specified EMC value, and items that usually have EMC but are removed from the pregenerated json file would not have EMC anymore.

What happened instead: None of the above happens, suggesting that the json file is not read.

This used to work perfectly fine before, I used the pregenerated EMC json file to overhaul EMC values in my modpack (to a level that can't be done easily with custom_emc.json, given that I removed EMC from about 99% of all items), yet for some reason this issue seemed to appear out of nowhere today, multiple people on my modpack's discord have reported this issue today even though neither the modpack nor ProjectE has been updated today, which is quite weird.

AmmoniumX commented 1 year ago

Also, I have confirmed that this bug appears on a brand new forge install with only ProjectE installed (and JEI).

AmmoniumX commented 1 year ago

Apparently, this was due to a bug with a Minecaft launcher version released yesterday, but it appears to have gotten fixed now.