sinkillerj / ProjectE

ProjectE. A complete rewrite of EE2 for modern Minecraft versions.
MIT License
394 stars 203 forks source link

[Suggestion] Per-datapack EMC Values #2284

Closed CraftSpider closed 1 year ago

CraftSpider commented 1 year ago

Tickets that do not conform to this template will be closed without comment

Exact ProjectE version (do not say "latest", "latest on Curse", or similar):

1.0.1B

Exact Forge version:

43.2.8

Desired Feature:

Instead of one massive custom_emc.json, I'd like to be able to split it up for re-use - I'd like to be able to make a datapack for 'Biome's You Go items' and another for 'Thermal items', so that I can re-use these files for packs with the same mods, rather than have to hunt through them to copy over just the bits I want. I think this is useful in part because most of the time, packs use the default EMC values, and these packs can be tuned to match that default balance, and be drop-in for anyone who wants the support.

pupnewfster commented 1 year ago

This is already possible via custom conversions which ProjectE uses to define defaults for things like vanilla.

Example file: https://github.com/sinkillerj/ProjectE/blob/mc1.19.x/example_custom_conversion.json (might be slightly out of date I forget) ProjectE's own datapack that has conversions and values defined: https://github.com/sinkillerj/ProjectE/tree/mc1.19.x/src/datagen/generated/data/projecte/pe_custom_conversions

Basically any conversion json files found in a pe_custom_conversions subfolder of a datapack will be loaded.

CraftSpider commented 1 year ago

Ah, thank you, that's exactly the kind of thing I was looking for, and supports some stuff I was missing - the whole 'custom conversion' stuff looks great for not needing to manually propagate values across non-standard crafting methods. Thank you, sorry I missed it!