search

sinkillerj / ProjectE

ProjectE. A complete rewrite of EE2 for modern Minecraft versions.
MIT License
406 stars 206 forks source link

[1.7.10] (SOLVED) A fatal error displayed, cannot rejoin world after using Tome of Knowledge #2301

Closed awbarr closed 1 year ago

awbarr commented 1 year ago

Tickets that do not conform to this template will be closed without comment

Exact ProjectE version (do not say "latest", "latest on Curse", or similar): ProjectE-1.7.10-PE1.10.1

Exact Forge version: Forge-1.7.10-10.13.4.1614-1.7.10 (Server)

Link to crash log (please use a paste site, do not attach the .txt or paste the log inline): https://pastebin.com/C3VTsHHS

Steps to reproduce:

  1. Exist with my modpack (496 mods)
  2. Load into a world, use a Tome of Knowledge on a transmutation table
  3. Get disconnected from the world forcibly due to a "fatal error"
  4. Try rejoining only to be disconnected continuously
  5. Find out in the logs (attached) that there is a Null Pointer Exception prohibiting you from rejoining because of a knowledge synchronization packet that doesn't have any NBT data, but because there's no null checker in that portion of the code it will throw the error
  6. Figure out that the error is coincidentally followed by a similar SimpleChannelHandlerWrapper exception thrown by SanAndreas Turret Mod that was made with Beta 1.7.10

What I expected to happen:

What happened instead:

I created this issue so anyone with an issue like this one can hopefully retrace my steps and determine the issue on their own pack. It might not be the exact same mod from the same niche, but going off of my logs and my input will hopefully help others figure out their problem. In my case, the turret mod was very basic in 1.7.10 (it was in beta) and OMT is much better and more thorough, so I have absolutely no problem removing it.

However, if the plugin author intends on fixing smaller issues like these even for ancient versions of Minecraft, including some null checks within the KnowledgeSyncPKT class and TransmutationProps class should resolve issues like these. If you need any more information from my end, please let me know and I will try to provide.

awbarr commented 1 year ago

Quick edit: after testing a bit more thoroughly in a creative world, it appears even without that specific mod it will still disconnect you for the same reason, but in this case you can still log back in normally. The only issue is it seems like while the tome works and you can access everything, it consumes the EMC of the book, so if you want your EMC back you'll have to cheat in another book so you can get the value of it applied properly.