sinkillerj / ProjectE

ProjectE. A complete rewrite of EE2 for modern Minecraft versions.
MIT License
405 stars 208 forks source link

Way to go #307

Closed WittyYeti closed 9 years ago

WittyYeti commented 9 years ago

Way to please "your" users! I say "your" because you're just taking credit for MozeIntel's work :)

I don't usually interfere within other peoples mods, but this is just stupidity at it's finest. Deleting all issues? Removing feedback from your users? Pretty much wiping out MozeIntel's name? Come on...

When you take control of a project you take control of the entire project, including all of the issues. You also leave the initial author's package name intact and you place your new code in YOUR package, not rename the entire thing...

If you see this as hate, you're more childish than I thought.Go ahead and delete my comment like you have all other feedback :smile:

sinkillerj commented 9 years ago

Firstly I'll address the credit issue. Moze wanted to transfer ownership, not appoint a temporary maintainer. Going forward I will be the main developer which is why the packages were renamed, however Moze will always be credited and has been, a credits section was even added to the readme.md. He will also remain in the mcmod.info, and If a better way to give credit in the future comes up he will be listed there as well. ProjectE will always be his baby, and if he ever wants to reclaim it I will promptly give it back to him.

Nextly, the issues. The issues section was in bad shape, my intention is not and was not to simply ignore the issues, in retrospective I will admit that having everyone recreate issue reports under the new guidelines was a bad idea.

As for deletion and blocking, only two users have been affected by this, and I am fully willing to unblock them however they will need to show a bit more maturity.

I care about ProjectE and plan to support it long into the future, but I have only had it for one day, give things some time before thinking the worst. In the meantime you can and are encouraged to keep providing ideas and issues, I simply ask that you keep in constructive.

WittyYeti commented 9 years ago

I get that, I really do. But don't you think that it's just etiquette to leave the package names intact? Please don't take this the wrong way, but I've been a programmer for a long time and in all my time working with open source projects, even projects that fortune 500 companies have passed down, they still leave the package names intact. Not to mention the issues it's going to cause your end users. You've just broke worlds for people using ProjectE.

As long as you realize your mistakes, I can respect that. It's not just me you need to say this too though, it may be worth your time to announce it to your users.

I admit, I may have gotten the wrong side of the stick here. My apologies.

I understand that, but first impressions mean a lot, and this isn't me judging you or the project, but you've made a bad one. I have to agree with the constructive criticism.

You seem mature enough to undertake the project, but you've got to understand that the modding community can be.. rough. It's all about pleasing your end users. I wish you the best in the future.

elifoster commented 9 years ago

Plenty of mods still keep their old package names when switching authors, and that's for a reason: mod support. Having to push an update for a mod just because some mod decided that it would change all of its package names is ridiculously stupid.

Underground Biomes is still using the same package names from years ago.

Flaxbeard's Steam Power is still using the same package names from when Flax developed it.

MaPePeR commented 9 years ago

I can totally understand the issues-deletion, but packages should not be shotgun renamed. Basically for the reasons satanic Santa pointed out, but also because you just said that you will give the project back to moze Intel, if he asks for it: you never want to do package renaming like this twice in a project. That has nothing to do with giving credit, but with coding standards. Renaming packages like this is worse than goto.

dries007 commented 9 years ago

@sinkillerj Apart from the package renaming, which is a bit NoNo for various reasons, most notably mod compatability, here is a thing I wrote, thought about and then decided to post, even if it would lead to me being added to the blocklist:

Nextly, the issues. The issues section was in bad shape, my intention is not and was not to simplyy ignore the issues, in retrospective I will admit that having everyone recreate issue reports under the new guidelines was a bad idea.

As for deletion and blocking, only two users have been affected by this, and I am fully willing to unblock them however they will need to show a bit more maturity.

Oh, "show a bit more maturity", such as removing issues because they come from someone with (apparently valid) concerns for the integrity of ProjectE. I'm sorry but you have made yourself a bad reputation within ~24h of the takeover.

You are aware that the list of issues still valid was actually made to help you, and the 2 other issues had nothing to do with the conflict at all.

There is reasonable sized group of people who are looking to just bypass you and maintain there own version of ProjectE, but I'm sure that won't be necessary, there are better ways to resolve this conflict.

LemADEC commented 9 years ago

so you made mistake and through a fit? great! now be mature and reopen those closed issues.

bengalgod commented 9 years ago

I admit to being genuinely annoyed that people are still talking about this. The energy being put into criticizing the new support for this mod could instead be spent improving the mod through testing and reporting bugs. I don't know this guy, I didn't know the first guy, and my attachment to this mod pretty much stops at "man, EE2 was awesome, it's cool that somebody converted it to 1.7.10"

sinkillerj commented 9 years ago

The package renaming will be reverted. As for the two users, I will unblock them in a bit, but if they continue to post hate speech instead of constructive discussion they will return to the block list.

elifoster commented 9 years ago

lol there was no hate speech. They were telling you that some bugs were still present.

sinkillerj commented 9 years ago

There was a bit more than what they used as evidence in their social media case, but they have now been unblocked.

elifoster commented 9 years ago

GitHub =/= social media.

Your behavior is making me worry about this mod and the future of it. I don't personally use it, but I still have my concerns.

sinkillerj commented 9 years ago

GitHub may not be, but the issue extends far beyond GitHub. I have been reading everything thats been said, here, on Twitter, on forums, and I'm attempting to make everyone happy which is not a easy task on the internet. I hope eventually I can change your opinion on the state of the project.

elifoster commented 9 years ago

I hope you can as well :)

(I probably still won't use the mod; I'm a GregTech user that has a heavy concern for balance. I may document it at some point though).

grydian commented 9 years ago

What about all the closed issues? There were 80+ and if you just expect others to reopen them its possible bugs will slip through the cracks. Why not go through and open the ones that obviously still an issue? The way things are now basically expects everyone to get over this drama and do more work for you we already have done. The confusion you are creating here isn't good.

sinkillerj commented 9 years ago

I will be reading them and pushing fixes, reopening them as necessary.

grydian commented 9 years ago

ok great :)

dries007 commented 9 years ago

@sinkillerj I still have Clays list of issues, he retested them all on the latest devbuild before he posted that, I made sure of that, so it should be a good guideline for what issues are useful.

sinkillerj commented 9 years ago

@dries007 He reposted them personally in #310 and I will be looking through them.