search

sinkingpoint / prometheus-gravel-gateway

A Prometheus Aggregation Gateway for FAAS applications
GNU Lesser General Public License v3.0
115 stars 10 forks source link

Why is there a TODO for prometheus distributions summaries? #18

Closed lhess closed 1 year ago

lhess commented 1 year ago

While trying out the gravel gateway, I noticed that the aggregation of distribution summaries is not supported. I stumbled over this while using distribution summaries.

May I ask what was the reason for not implementing it? Maybe I can help here :)

Thanks a lot!

PS: For now, this detail is maybe worth to be mentioned in the readme.

lhess commented 1 year ago

Just found this: https://github.com/weaveworks/prom-aggregation-gateway/blob/master/cmd/prom-aggregation-gateway/main.go#L121

Although I am still wondering why it is not possible to merge summaries...

lhess commented 1 year ago

I think this issue can be closed: https://prometheus.io/docs/practices/histograms/#errors-of-quantile-estimation

sinkingpoint commented 1 year ago

Correct - there's no real logical way to merge individual summaries together. That behing said, we can improve the errors under this issue. It's not great to just throw a todo