search

sinkingsugar / fragments

Collection of pure Nim utilities
MIT License
57 stars 5 forks source link

Fragments requires nim version 0.19.9 that doesn't exist #2

Closed lolgab closed 5 years ago

lolgab commented 5 years ago

I don't know what is the real minimum required version (if 0.19.0 or 0.19.2) but maybe a typo made it 0.19.9.

lolgab commented 5 years ago

I saw right now that it points to a custom (maybe dev) version of nim present in your conda channel. It will be installed if you use your conda method.

lolgab commented 5 years ago

I noted that with default setup it doesn't find the ATen/ATen.h include file. I had to link the /lib/include content to /include dir to let the linker see it.

ln -s $ATEN/lib/include/** $ATEN/include

You should add $ATEN/lib/include/ to the include PATH

sinkingsugar commented 5 years ago

0.19.9 is the development version also on the main nim repository. Probably nimble is not picking it either tho. Thanks for pointing it out! We will check.

sinkingsugar commented 5 years ago

I noted that with default setup it doesn't find the ATen/ATen.h include file. I had to link the /lib/include content to /include dir to let the linker see it.

ln -s $ATEN/lib/include/** $ATEN/include

You should add $ATEN/lib/include/ to the include PATH

Did you fetch nimtorch from conda recently? Should be fine as it is here defined fine: https://github.com/fragcolor-xyz/nimtorch/blob/451769c517c4384fc7929d5d723942049acdc6b1/torch/torch_cpp.nim#L64

lolgab commented 5 years ago

Nice, probably I messed up with installation because at start I wanted to install it from nimble. Thank you.

sinkingsugar commented 5 years ago

Makes sense actually! I did not tag a new version of nimtorch in a while :) Fixed both hopefully now! Thanks for your report.