search

sinkovit / Spatial-ecology

Space use software deployed in the Spatial Ecology Gateway
MIT License
2 stars 0 forks source link

PR: added ability to read data file from the gateway #39

Closed monaw closed 1 year ago

monaw commented 1 year ago

Done for issue #8 : User upload from gateway home directory and also updated changed code in bin/

sinkovit commented 1 year ago

Thanks for adding this feature. Just make sure that this does not break ability to read from local file on the user's computer.

monaw commented 1 year ago

hi @sinkovit, to merge the changes from the feature branch to main, you need to click on the "Merge pull request" green button below (on left side) first before closing the PR. i've reopened the PR so you can give that another try, thanks!

by the way, yes i did test and reading data from user's own computer still works and should be tested one more time when this feature gets released to the gateway (:

monaw commented 1 year ago

hmm, still not merge...let me give it a try...

monaw commented 1 year ago

hi Bob, now the PR code is merged; not sure why it didn't work for you...did you click on the green "Confirm merge" button?

sinkovit commented 1 year ago

I thought I did, but I’m guessing that I didn’t. Thanks for your patience!

-- Bob

From: MonaW @.> Reply-To: sinkovit/Spatial-ecology @.> Date: Wednesday, January 11, 2023 at 5:56 PM To: sinkovit/Spatial-ecology @.> Cc: "Sinkovits, Robert" @.>, State change @.***> Subject: Re: [sinkovit/Spatial-ecology] PR: added ability to read data file from the gateway (PR #39)

hi Bob, now the PR code is merged; not sure why it didn't work for you...did you click on the green "Confirm merge" button?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/sinkovit/Spatial-ecology/pull/39*issuecomment-1379712172__;Iw!!Mih3wA!HvUnm5HN5zc8hXeZzmNXKP8U9VfUdVbrTjFyWjjqFqbTiaEwQZ58ikhANbOxBcEpgXI4ij4y7XOq7YWFLMV-v5aq$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ABH5QMB3JRPVWCND32VRS3DWR5QE5ANCNFSM6AAAAAATYSGHT4__;!!Mih3wA!HvUnm5HN5zc8hXeZzmNXKP8U9VfUdVbrTjFyWjjqFqbTiaEwQZ58ikhANbOxBcEpgXI4ij4y7XOq7YWFLF4dHy6b$. You are receiving this because you modified the open/close state.Message ID: @.***>

monaw commented 1 year ago

you are very welcome; happy to do it together next time if you want (: