search

sinkovit / Spatial-ecology

Space use software deployed in the Spatial Ecology Gateway
MIT License
2 stars 0 forks source link

Fix Movebank data loading #64

Closed monaw closed 11 months ago

monaw commented 11 months ago

James got a strange message when loading data from Movebank.

i did some testing and couldn't get the error message to display in the app for loading invalid file or giving wrong authentication to the Movebank load option!

monaw commented 11 months ago

After going through the commits on the dev branch, it appears that the error message that should appear when there is a problem loading data stopped appearing at commit b555ad0; commit 0774e6d works (note, must use the src/shiny/app.R, not the one in bin/app.R and also these 2 versions don't yet handle reloading of new data so must test by loading bad file first!

The change that made the difference is in app.R, "observeEvent (input$load_data, {" crashes but "table_all.data <- eventReactive(input$load_data, {" works...show's the error message when loading bad data (must be the first data load as the code didn't handle loading new data yet.

The b555ad0 commit changed allow the table to be updated when loading new data.

However, in the current code, "eventReactive(input$data_load_btn, {" doesn't work...the event doesn't seem to activate when loading data and "observeEvent(input$data_load_btn, {" works.

monaw commented 11 months ago

i'm thinking that the issue may be validate() doesn't work within observeEvent! so i need to figure out another way to display our error messages...

monaw commented 11 months ago

ok, replaced validate with showNotification which is working much nicer!