search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
802 stars 105 forks source link

Convert timer delay to number if not already #322

Closed arielweinberger closed 4 years ago

arielweinberger commented 4 years ago

Purpose

Fix issue #315 by checking if timer.delay is a number. If it isn't make it one by parsing it to an integer.

benjamingr commented 4 years ago

Hey this looks cool - would you mind adding a test?

codecov[bot] commented 4 years ago

Codecov Report

Merging #322 into master will increase coverage by 0.36%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   92.75%   93.11%   +0.36%     
==========================================
  Files           1        1              
  Lines         552      552              
==========================================
+ Hits          512      514       +2     
+ Misses         40       38       -2
Flag Coverage Δ
#unit 93.11% <100.00%> (+0.36%) :arrow_up:
Impacted Files Coverage Δ
src/fake-timers-src.js 93.11% <100.00%> (+0.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f8322e...a0ac099. Read the comment docs.

benjamingr commented 4 years ago

(Tests are basically one big file https://github.com/sinonjs/fake-timers/blob/master/test/fake-timers-test.js )

arielweinberger commented 4 years ago

@benjamingr test added

benjamingr commented 4 years ago

Thanks!