search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
802 stars 105 forks source link

Need new release #337

Closed fristedt closed 3 years ago

fristedt commented 4 years ago

Our project needs a fix introduced in June (https://github.com/sinonjs/fake-timers/issues/304), but the latest release was made in March.

When are you planning on making a new release?

benjamingr commented 4 years ago

@fatso83 - can you make a release? Otherwise I can try doing one but I never did one before for fake-timers.

We can also set up releases to happen from the CI so they are more frequent

fatso83 commented 4 years ago

Having automated CI releases would be a good thing. We just need to be strict about semantic versioning wrt labels on merged issues. I won't be leading any effort, though; just back from a 5-months code hiatus, so I'm a bit rusty.

I'll see if I can get to making a release this weekend. It's just a matter of following some steps in a markdown file and it's done in a few minutes. Only thing is that I consistently forget pushing the tag afterwards 🤦

fatso83 commented 4 years ago

~A recent dependency update broke our builds on Safari, IE and Firefox, so I need to revert that first.~ edit: see below

fatso83 commented 4 years ago

@benjamingr This build broke when #325 (stack traces) was merged in June. It has been broken since. This blocks creating a new release. See details in https://github.com/sinonjs/fake-timers/pull/325#issuecomment-691995306

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

fatso83 commented 3 years ago

@benjamingr Morgan cut a new release so this should close.