search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
802 stars 105 forks source link

Remove misleading comment #340

Closed mroderick closed 3 years ago

mroderick commented 3 years ago

This repository doesn't use the no-prototype-methods rule that is managed with local-rules plugin, so the comments make no sense.

ESLint should really throw an error here...

How to verify

  1. Check out this branch
  2. search the codebase for local-rules
  3. Observe that there are no results
codecov[bot] commented 3 years ago

Codecov Report

Merging #340 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files           1        1           
  Lines         555      555           
=======================================
  Hits          517      517           
  Misses         38       38
Flag Coverage Δ
#unit 93.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8e7af4...5db2db4. Read the comment docs.

SimenB commented 3 years ago

ESLint should really throw an error here...

We can either run eslint with --report-unused-disable-directives or enable https://github.com/mysticatea/eslint-plugin-eslint-comments/blob/master/docs/rules/no-unused-disable.md