search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
797 stars 104 forks source link

chore: add type tests #373

Closed SimenB closed 3 years ago

SimenB commented 3 years ago

Purpose (TL;DR) - mandatory

https://github.com/sinonjs/fake-timers/issues/356#issuecomment-768227159

I just added a dummy test, no attempt at coverage. But it's a good opportunity for new contributors if they want, and future changes to the types should include tests

codecov[bot] commented 3 years ago

Codecov Report

Merging #373 (9e1a23c) into master (c39e970) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           1        1           
  Lines         553      553           
=======================================
  Hits          517      517           
  Misses         36       36
Flag Coverage Δ
unit 93.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c39e970...9e1a23c. Read the comment docs.

mroderick commented 3 years ago

This looks like a good start to me. @SimenB can you think of any reason not to merge this?

SimenB commented 3 years ago

Only reason would be if we wanted more tests before landing, but I think it's valuable as is 👍