search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
797 stars 104 forks source link

Drop IE11 and Safari 9 from Sauce Labs test runners #376

Closed fatso83 closed 3 years ago

fatso83 commented 3 years ago

Purpose (TL;DR) - mandatory

Background (Problem in detail) - optional

See discussion in #375 and sinonjs/sinon#2359

codecov[bot] commented 3 years ago

Codecov Report

Merging #376 (3e07631) into master (07d90ce) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           1        1           
  Lines         553      553           
=======================================
  Hits          517      517           
  Misses         36       36
Flag Coverage Δ
unit 93.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07d90ce...3e07631. Read the comment docs.

benjamingr commented 3 years ago

Should we do a version that modernizes the codebase? (I'm happy to run the code through transforms that modernize it if we don't need to support IE11)

fatso83 commented 3 years ago

I would not mind that. The only problem I have with large touch-everything stuff like running Prettier, Eslint and transforms on the code is that it makes git blame a lot less useful, but I can live with that.