sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS

BSD 3-Clause "New" or "Revised" License

797 stars 104 forks source link

Update eslint config #385

Closed fatso83 closed 3 years ago

fatso83 commented 3 years ago

Purpose (TL;DR) - mandatory

Update fake-timers to use latest @sinonjs/eslint-config

Background (Problem in detail) - optional

Was unable to write ES2015+ syntax, even though it should have worked. Also found lots of config I do not think is needed.

Solution

Removed all errors. Still 129 eslint warnings remaining - all concerning either missing jsdoc or errors in the types

codecov[bot] commented 3 years ago

Codecov Report

Merging #385 (6586030) into master (ec67ab3) will not change coverage. The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files           1        1           
  Lines         551      551           
=======================================
  Hits          515      515           
  Misses         36       36

Flag	Coverage Δ
unit	`93.46% <83.33%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/fake-timers-src.js	`93.46% <83.33%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec67ab3...6586030. Read the comment docs.

mroderick commented 3 years ago

I don't know what codecov is complaining about. The coverage looks fine on my computer

--------------------|----------|----------|----------|----------|-------------------|
File                |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
--------------------|----------|----------|----------|----------|-------------------|
All files           |    93.48 |    88.92 |    94.12 |    93.47 |                   |
 fake-timers-src.js |    93.48 |    88.92 |    94.12 |    93.47 |... 1382,1383,1384 |
--------------------|----------|----------|----------|----------|-------------------|

fatso83 commented 3 years ago

Looked fine to me as well. I think we should wait releasing a new major until we have merged in a removal of the TS definitions. Then we could fix up the current invalid jsdoc syntax as well.