search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
797 stars 104 forks source link

Issue 390 implicit dependencies on faking interval #391

Closed fatso83 closed 3 years ago

fatso83 commented 3 years ago

Purpose (TL;DR) - mandatory

Remove implicit dependency on *Interval functions in the shouldAdvanceTime feature.

Background (Problem in detail) - optional

See #390

codecov[bot] commented 3 years ago

Codecov Report

Merging #391 (830d73e) into master (cc30595) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   93.84%   93.85%   +0.01%     
==========================================
  Files           1        1              
  Lines         585      586       +1     
==========================================
+ Hits          549      550       +1     
  Misses         36       36
Flag Coverage Δ
unit 93.85% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fake-timers-src.js 93.85% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc30595...830d73e. Read the comment docs.

fatso83 commented 3 years ago

Not heard anything. Merging.