search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
794 stars 103 forks source link

fix: handle missing stack when throwing recursion errors #401

Closed SimenB closed 2 years ago

SimenB commented 2 years ago

This is for #398 which I think we should land and release as 8.0.1. Guards against the error and falls back to the behavior of v7

fatso83 commented 2 years ago

So ... what's the order of things here? #398 and then #401 and then #402?

SimenB commented 2 years ago

I think this, release, then figure out what to do in #398 (I'm not totally happy with it)

SimenB commented 2 years ago

I'll rebase both to trigger CI 🙂

codecov[bot] commented 2 years ago

Codecov Report

Merging #401 (e4d9c9c) into master (f434b69) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   93.85%   93.87%   +0.02%     
==========================================
  Files           1        1              
  Lines         586      588       +2     
==========================================
+ Hits          550      552       +2     
  Misses         36       36
Flag Coverage Δ
unit 93.87% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fake-timers-src.js 93.87% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f434b69...e4d9c9c. Read the comment docs.