search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
804 stars 106 forks source link

chore: run prettier as part of eslint #404

Closed SimenB closed 3 years ago

SimenB commented 3 years ago

Purpose (TL;DR) - mandatory

I didn't know we had prettier set up (https://github.com/sinonjs/fake-timers/runs/3673842832?check_suite_focus=true) - it's better to just run it as part of eslint both for eslint --fix and the pre-commit hook. And my IDE will now autoformat on save 🙂

Note that we can probably remove the prettier --check thing as eslint will now report any formatting errors.

Negates the need for #402

codecov[bot] commented 3 years ago

Codecov Report

Merging #404 (0e2b4c1) into master (f434b69) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files           1        1           
  Lines         586      586           
=======================================
  Hits          550      550           
  Misses         36       36
Flag Coverage Δ
unit 93.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f434b69...0e2b4c1. Read the comment docs.

fatso83 commented 3 years ago

Nice cleanup!

mroderick commented 2 years ago

I don't think this was necessary, but if it makes you happier to configure your IDE this way ... 🤷

fatso83 commented 2 years ago

Does all the things the old stuff did and a bit more, while making the dev tools people use play better: seems like a win to me 👍