sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
794 stars 103 forks source link

chore(ci): do not hard code node versions #417

Closed SimenB closed 2 years ago

SimenB commented 2 years ago

Purpose (TL;DR) - mandatory

I assume the purpose is to always run on an LTS version of node here. So specifying lts/* does the same thing, but does not have to be updated when v18 (and v20 etc) becomes LTS

codecov[bot] commented 2 years ago

Codecov Report

Merging #417 (978f890) into master (16592d6) will increase coverage by 1.29%. The diff coverage is n/a.

:exclamation: Current head 978f890 differs from pull request most recent head 5430157. Consider uploading reports for the commit 5430157 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   94.17%   95.46%   +1.29%     
==========================================
  Files           1        1              
  Lines         618      618              
==========================================
+ Hits          582      590       +8     
+ Misses         36       28       -8     
Flag Coverage Δ
unit 95.46% <ø> (+1.29%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fake-timers-src.js 95.46% <0.00%> (+1.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16592d6...5430157. Read the comment docs.

fatso83 commented 2 years ago

Great small fix!