search

sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
794 stars 103 forks source link

IdleDeadline feature #421

Closed soferdani closed 5 months ago

soferdani commented 2 years ago

Fix issue #358 create IdleDeadline functionality for the requestIdleCallback

Please have a look at the requestIdleCallback test section I comment out. I couldn't make this test work, and I think it's because the new feature open the callback and call it with the IdleDeadline object I created.

codecov[bot] commented 2 years ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ead4842) 95.49% compared to head (48f1995) 95.37%. Report is 77 commits behind head on main.

Files Patch % Lines
src/fake-timers-src.js 92.85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #421 +/- ## ========================================== - Coverage 95.49% 95.37% -0.12% ========================================== Files 1 1 Lines 621 627 +6 ========================================== + Hits 593 598 +5 - Misses 28 29 +1 ``` | [Flag](https://app.codecov.io/gh/sinonjs/fake-timers/pull/421/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/sinonjs/fake-timers/pull/421/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs) | `95.37% <92.85%> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sinonjs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fatso83 commented 1 year ago

Thanks for this. I did have a quick look, but I guess getting those stack traces right is non-trivial and I can't see exactly what it is to be done by a quick glance.

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

fatso83 commented 5 months ago

It's been two years and it has not moved much. I have no personal interest in this, so for this to go forward, someone needs to pick it up. I can't debug on something I really do not know anything about. Will close, but can reopen if someone picks it up!