sinonjs / fake-timers

Fake setTimeout and friends (collectively known as "timers"). Useful in your JavaScript tests. Extracted from Sinon.JS
BSD 3-Clause "New" or "Revised" License
794 stars 103 forks source link

test(shouldAdvanceTime): add test that check that time is still updated even with sync work #423

Closed rluvaton closed 2 years ago

rluvaton commented 2 years ago

Purpose (TL;DR) - mandatory

Adding test case for #422

rluvaton commented 2 years ago

@benjamingr

rluvaton commented 2 years ago

I think you should stop the tests this will just run until killed, the tests are stuck because of the sync code

benjamingr commented 2 years ago

Ok, talked about how to fix it by waiting for a timer on whatsapp

rluvaton commented 2 years ago

Closing, see https://github.com/sinonjs/fake-timers/issues/422#issuecomment-1038403540 why