Open Oustinger opened 10 months ago
Oooh, I somehow missed that this was added. Sorry about the late look, but while this is interesting, my head is a bit fried 🤯 This is quite a big change, so I (or someone else with a bigger head) needs to take a new look with a fresh head!
Thanks for providing a fix to something that bugged you a year ago. That's persistence we can appreciate 😄
It's a bit scary breaking change, so I think I would like some more 👀 on this before going ahead.
I started reviewing it and came to the "bit scary" conclusion as well.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Fix issue #437 by creating ClockDate as JS class and extending it from NativeDate
Why I did this way:
ClockDate
by JS function)ClockDate
can't be correct instance to extend from it. That's why I replaced function on class. And it resolved my problem.Date()
withoutnew
keyword I solved by usingProxy
instance.mirrorDateProperties
function. It's not needed any more.But I had some troubles with tests:
ClockDate.prototype
never equals toDate.prototype
, becauseClockDate
is extended fromDate